Skip to content

LogMessage: Do not print null message #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

LogMessage: Do not print null message #360

merged 1 commit into from
Oct 16, 2019

Conversation

@frauzufall
Copy link
Member

@frauzufall frauzufall commented Oct 14, 2019

  • Prevent printing of log message if message is null

How to reproduce:

DefaultLogger log = new DefaultLogger(System.out::println, LogSource.newRoot(), LogLevel.INFO);
try {
	((Object)null).equals(null);
} catch (NullPointerException e) {
	log.error(e);
}

.. prints:

[ERROR] null
java.lang.NullPointerException
	at org.scijava.log.LogTest.run(LogTest.java:12)

With this PR, it prints

[ERROR] java.lang.NullPointerException
	at org.scijava.log.LogTest.run(LogTest.java:12)

@frauzufall
LogMessage: Do not print null message
fd9078e 
* Prevent printing of log message if message is null
@ctrueden ctrueden merged commit 6ebe5ec into master Oct 16, 2019
@ctrueden
Copy link
Member

ctrueden commented Oct 16, 2019

Thank you!

@ctrueden ctrueden deleted the logmessage-fix-null branch October 16, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frauzufall @ctrueden